Deploy only if RC is released #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsrahul1001
requested review from
phanikumv,
pankajastro,
pankajkoti,
Lee-W,
sunank200 and
utkarsharma2
as code owners
Lee-W
approved these changes
Dec 22, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1396 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 94 94
Lines 4635 4635
=======================================
Hits 4558 4558
Misses 77 77 ☔ View full report in Codecov by Sentry. |
|
is this PR needed @vatsrahul1001 ? |
Lee-W
force-pushed
the
deploy-only-if-rc-released
branch
from
37b9ac5 to
a962516
Compare
pankajkoti
reviewed
Mar 15, 2024
|
@vatsrahul1001 can we merge this if we were able to test this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our RC test workflow was updating the deployment and running the master DAG even if there was no RC release. This PR only initiates deployment and DAG triggers when we have an RC release.