Revert "Pin max versions for CNCF Kubernetes and Google Airflow providers (#1359)" #1368
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ders (#1359)" This reverts commit 76d082c. Since even if we pin the max version, there could be a possibility that the cncf kubernetes provider version is upgraded in the deployment and hence the pin won't be effective. It was decided to revert the removal of required PodLoggingStatus object in Airflow OSS and corresponding PR has been merged which can be tracked in the linked issue. closes: #1366
pankajkoti
requested review from
phanikumv,
pankajastro,
Lee-W,
sunank200,
utkarsharma2 and
vatsrahul1001
as code owners
|
Tests will succeed once the CNCF provider with the revert PR in OSS is released. |
ephraimbuddy
approved these changes
Nov 24, 2023
|
cc: @Lee-W @ephraimbuddy @phanikumv Gentle reminder that we need to make a release including this after the providers are released tonight and include the new release in runtime. |
Lee-W
approved these changes
Nov 27, 2023
|
as apache/airflow#35845 has been released, gonna merge this one and release 1.18.3 |
|
I just found out it was just accepted not released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 76d082c.
Since even if we pin the max version, there could be a possibility that
the cncf kubernetes provider version is upgraded in the deployment
and hence the pin won't be effective. It was decided to revert the
removal of required PodLoggingStatus object in Airflow OSS and
corresponding PR has been merged which can be tracked in the linked
issue.
closes: #1366