Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image index to each row when reading images #97

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

JulienPeloton
Copy link
Member

Thanks to #91, I realized that the user completely loses the data order once the data read from spark-fits is written on disk. While this has no impact for tables (rows are independent), this matters a lot for images!

This PR introduces image index to easily track the provenance.

Note: if this is insufficient, we can add another column with row position within an image. But let's wait if this is really needed.

@codecov-commenter
Copy link

Codecov Report

Merging #97 into master will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   90.33%   90.49%   +0.15%     
==========================================
  Files           9        9              
  Lines         559      568       +9     
  Branches       70       74       +4     
==========================================
+ Hits          505      514       +9     
  Misses         54       54              
Impacted Files Coverage Δ
.../com/astrolabsoftware/sparkfits/FitsHduImage.scala 78.78% <100.00%> (+1.36%) ⬆️
.../astrolabsoftware/sparkfits/FitsRecordReader.scala 77.68% <100.00%> (+1.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 692c689...14f2991. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants