-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring: towards Fink v4 #948
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #948 +/- ##
=====================================
Coverage 83% 83%
=====================================
Files 21 21
Lines 1346 1393 +47
=====================================
+ Hits 1129 1170 +41
- Misses 217 223 +6 ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please create an issue first before opening a Pull Request.
Linked to issue(s): Closes #947
What changes were proposed in this pull request?
This PR completely reorganises the core of Fink to better handle the Rubin integration.
Notable changes:
/ztf/
and/rubin/
-s <survey>
to all binarieskafka_security_protocol
in the argumentssims
producer --> now the CI usesztf
(orrubin
later)Nightly streaming
Configuration file is unique for all jobs, and can be found at
${FINK_HOME}/conf
. The nightly operations consist of 3 jobs, wrapped in${FINK_HOME}/scheduler/launch_stream.sh
.The polling operation is launched at 00:01 on night N, where it starts polling data (which is not yet produced). Then when data finally arrives, the enrichment operation starts, followed by the distribution operation. All jobs stop at 20:00.
You can also manually launch part of the processing:
Database operations
This is now parametrised by
/home/julien.peloton/fink-broker/scheduler/ztf/launch_db.sh
.This job contains 4 steps:
If the merge went wrong, just manually clean the files:
And restart DB operations.
New schedule
We now start on night N.
How was this patch tested?
CI & local container