-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve e2e science, self-hosted test #796
Improve e2e science, self-hosted test #796
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
eff813f
to
0e8b6dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fjammes -- it is good to see all the test suite green again :-)
I left minor comments, but it is ready for merging.
e2e/check-results.sh
Outdated
count=0 | ||
while ! finkctl wait topics --expected "$EXPECTED_TOPICS" --timeout 60s -v1 | ||
do | ||
echo "Waiting for topics to be created" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would even be more specific and echo:
echo "Waiting for $EXPECTED_TOPICS topic(s) to be created"
e2e/fink-start.sh
Outdated
then | ||
for task in $tasks; do | ||
echo "--------- $task log file ---------" | ||
cat "/tmp/$task.log" | ||
done | ||
kubectl describe pods -l "spark-role in (executor, driver)" | ||
kubectl get pods | ||
echo "ERROR: unable to start fink-broker" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To ease the debug, I would print:
echo "ERROR: unable to start fink-broker in 300 seconds"
Configure fine-grained resource management Fix fink startup script error management Use 3GB memory for raw2science Configure number of expected topics for e2e test output
882631c
to
f34604a
Compare
|
What changes were proposed in this pull request?
Increase memory request to 3GB for raw2science pods
How was this patch tested?
In self-hosted CI