Skip to content

Conversation

@astrogilda
Copy link
Owner

Description

This PR addresses issue #183 by consolidating duplicate implementations of _generate_samples_single_bootstrap using the Template Method pattern.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • All existing tests pass without modification
  • Regression tests confirm identical behavior
  • Performance benchmarks show no degradation

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information

This refactoring:

  • Eliminates 15+ duplicate method implementations
  • Improves maintainability through DRY principle
  • Makes it easier to add new bootstrap types
  • Ensures consistent behavior across all bootstrap methods

Resolves #183

@astrogilda astrogilda force-pushed the main branch 2 times, most recently from a438726 to 8b5e410 Compare July 3, 2025 21:39
@astrogilda astrogilda force-pushed the refactor-183-consolidate-bootstrap-logic branch from 2fda4a8 to 8a764a2 Compare July 3, 2025 21:39
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 3, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor] Consolidate Bootstrap Generation Logic

2 participants