Skip to content

Conversation

@jacquesalice
Copy link
Member

Relates to DLC-2117. Fixed error by adding a conditional statement if Spitzer images were found. @rnikutta can you please review and Approve?

@jacquesalice jacquesalice requested a review from rnikutta August 18, 2025 23:46
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rnikutta
Copy link
Member

Hi @jacquesalice I took a look. Your PR seems to be a work-around, but the error lies really

a) in the fact that the currently installed versions of datalab, pyvo, and astroquery are mutually incompatible, and
b) that in newer versions of astroquery, there no longer is an sha (Spitzer Heritage Archive) module in the astroquery.ipac.irsa package. (I tried to find it elsewhere in astroquery v0.4.10, and in their release notes https://github.com/astropy/astroquery/releases but couldn't.

Digging more, it was actually flagged for removal: astropy/astroquery#2834
But I don't see that the ticket was closed.

The way to proceed is (if you can't find it where I failed):

  1. Write to the astroquery maintainers (Brigitta S and Adam G), or open an issue on their Github:

https://pypi.org/project/astroquery/0.4.10/
https://github.com/astropy/astroquery/issues

  1. Once we know the new suggested astroquery search for the SHA, we can proceed with updating the datalab package dependencies, and what's installed by default on our NB server.

PS: I made a new local Python env with conda, with Py3.12, pyvo 1.7, and astroquery 0.4.10, for testing purposes (no datalab package).

Until then, I suggest we close or pause this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants