Skip to content

Conversation

@mtshiba
Copy link
Contributor

@mtshiba mtshiba commented Nov 30, 2025

Summary

This is a follow-up to #20566.

I revisited the recursive_type_normalized_impl method and realized that the visitor parameter is no longer necessary (the method doesn't expand type aliases, so there's no risk of infinite recursion), so I removed it.
I also added some more comments to some parts.

Test Plan

N/A

@astral-sh-bot
Copy link

astral-sh-bot bot commented Nov 30, 2025

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

@astral-sh-bot
Copy link

astral-sh-bot bot commented Nov 30, 2025

mypy_primer results

Changes were detected when running on open source projects
scikit-build-core (https://github.com/scikit-build/scikit-build-core)
+ src/scikit_build_core/_logging.py:153:13: warning[unsupported-base] Unsupported class base with type `<class 'Mapping[str, Style]'> | <class 'Mapping[str, Divergent]'>`
- Found 41 diagnostics
+ Found 42 diagnostics

No memory usage changes detected ✅

@mtshiba mtshiba marked this pull request as ready for review November 30, 2025 04:44
@AlexWaygood AlexWaygood added internal An internal refactor or improvement ty Multi-file analysis & type inference labels Nov 30, 2025
@MichaReiser MichaReiser merged commit a6cbc13 into astral-sh:main Dec 1, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants