Skip invalid archives from GitHub during release #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/download-skip
branch
from
ae5e72e to
8492ae4
Compare
zanieb
changed the title
|
I feel like I'm slightly more inclined towards #732 than this, silently skipping a file looks like a good way to confuse ourselves in the future. |
|
It's not silent! We do log it. It's unlikely there's a consequence here since we validate we have all the artifacts we want? We'll just skip other files "silently" downstream anyway. It seems like without this, the release workflow will be more brittle — it will unexpectedly break when we add some additional intermediate artifact. |
zanieb
force-pushed
the
zb/download-skip
branch
from
8492ae4 to
14742f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like #705 somehow includes files we don't want now?
See https://github.com/astral-sh/python-build-standalone/actions/runs/16804083046/job/47592503471
#732 also resolves this, but maybe we want both? We validate we have the files we need later anyway, so it's annoying for this to be fatal.