-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable tls-resumption for tls jobs #2073
Merged
DeagleGross
merged 26 commits into
aspnet:main
from
DeagleGross:dmkorolev/tls/disable-resumption
Mar 14, 2025
Merged
feat: disable tls-resumption for tls jobs #2073
DeagleGross
merged 26 commits into
aspnet:main
from
DeagleGross:dmkorolev/tls/disable-resumption
Mar 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Kestrel disable is done via SslServerAuthenticationOptions.AllowTlsResume.
For http.sys I have added code to control it as netsh parameters:
but due to underlying OS dependency, not all agents support it, so I am controlling resumption via registry settings of SChannel.
Validation of TLS Resumption being turned off was done via openssl traces. In example
And for next request we can see still
new
tls handshake and another session-id and session-ticket:That confirms that even trying to reuse the same session from client side, we end up establishing new tls handshake.