Add support for Alipay certificate signing #1131
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public const string Gender = "urn:alipay:gender"; | ||
|
|
||
| /// <summary> | ||
| /// OpenID is the unique identifier of Alipay users in the application dimension. |
Member
There was a problem hiding this comment.
What is an "application dimension"?
| public const string OpenId = "urn:alipay:open_id"; | ||
|
|
||
| /// <summary> | ||
| /// Alipay user system internal identifier, will no longer be independently open in the future, and will be replaced by OpenID. |
Member
There was a problem hiding this comment.
will no longer be independently open in the future
I don't understand what this means.
Comment on lines
+56
to
+57
| var app_cert_sn = await Options.PrivateKey(Options.AppCertSNKeyId, Context.RequestAborted); | ||
| var alipay_root_cert_sn = await Options.PrivateKey(Options.RootCertSNKeyId, Context.RequestAborted); |
|
|
||
| private const string SignType = "RSA2"; | ||
|
|
||
| private async Task AddCertSignatureParametersAsync(SortedDictionary<string, string?> parameters) |
Member
There was a problem hiding this comment.
Suggested change
| private async Task AddCertSignatureParametersAsync(SortedDictionary<string, string?> parameters) | |
| private async Task AddCertificateSignatureParametersAsync(SortedDictionary<string, string?> parameters) |
| } | ||
|
|
||
| /// <summary> | ||
| /// Get or set a value indicating whether to use certificate mode for signature implementation. |
Member
There was a problem hiding this comment.
Suggested change
| /// Get or set a value indicating whether to use certificate mode for signature implementation. | |
| /// Gets or sets a value indicating whether to use certificate mode for signature implementation. |
| /// <summary> | ||
| /// Gets or sets the optional ID for your Sign in with alipay_root_cert_sn. | ||
| /// </summary> | ||
| public string? RootCertSNKeyId { get; set; } |
Member
There was a problem hiding this comment.
Suggested change
| public string? RootCertSNKeyId { get; set; } | |
| public string? RootCertificateSubjectNameKeyId { get; set; } |
| public static class AlipayAuthenticationOptionsExtensions | ||
| { | ||
| /// <summary> | ||
| /// Configures the application to use a specified private to generate a client secret for the provider. |
Member
There was a problem hiding this comment.
Suggested change
| /// Configures the application to use a specified private to generate a client secret for the provider. | |
| /// Configures the application to use a specified private key to generate a client secret for the provider. |
| namespace AspNet.Security.OAuth.Alipay; | ||
|
|
||
| /// <summary> | ||
| /// https://github.com/alipay/alipay-sdk-net-all/blob/master/v2/AlipaySDKNet.Standard/Util/AntCertificationUtil.cs |
Member
There was a problem hiding this comment.
Please update this to a permalink that points to a specific Git SHA.
| /// <summary> | ||
| /// https://github.com/alipay/alipay-sdk-net-all/blob/master/v2/AlipaySDKNet.Standard/Util/AntCertificationUtil.cs | ||
| /// </summary> | ||
| internal static class AntCertificationUtil |
| return GetCertSN(cert); | ||
| } | ||
|
|
||
| public static string GetCertSN(X509Certificate2 cert) |
Member
There was a problem hiding this comment.
Does this code need to be this performance critical (e.g. with stackalloc)? Feels like it could be implemented more simply to make it easier to read and maintain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve #968