escape the dot in the regex, avoiding cases of garbage between two nu…

…mbers
asottile-archive · Dec 21, 2022 · 73a8e1e · 73a8e1e
1 parent 8f8f229
commit 73a8e1e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/_manylinux.py b/_manylinux.py
@@ -3,7 +3,7 @@
 import os
 import re
 
-PATTERN = re.compile(r'^(\d+).(\d+)$', re.ASCII)
+PATTERN = re.compile(r'^(\d+)\.(\d+)$', re.ASCII)
 
 
 def manylinux_compatible(major: int, minor: int, arch: str) -> bool:

diff --git a/tests/manylinux_max_test.py b/tests/manylinux_max_test.py
@@ -25,3 +25,12 @@ def test_environment_variable_is_garbage():
 
     msg, = excinfo.value.args
     assert msg == 'invalid MANYLINUX_MAX, expected `#.##` got `garbage`'
+
+
+def test_environment_variable_non_dot():
+    with mock.patch.dict(os.environ, {'MANYLINUX_MAX': '2_28'}):
+        with pytest.raises(ValueError) as excinfo:
+            manylinux_compatible(2, 28, 'x86_64')
+
+    msg, = excinfo.value.args
+    assert msg == 'invalid MANYLINUX_MAX, expected `#.##` got `2_28`'