feat: improved completions for version in commands for asdf.nu #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved completions for commands such as `asdf global <name> <version>` to list the installed versions Added "complete asdf plugin versions installed" and "complete asdf plugin versions all" that produce completions for the installed versions and for all versions available for a given plugin Improved `asdf install` completion to list the installed plugins and all the available versions
|
Ок |
OJarrisonn
changed the title
Stratus3D
reviewed
Dec 17, 2024
| let versions = ^asdf list $plugin | ||
| | lines | ||
| | each { |line| $line | str trim } | ||
| | each { |version| if ($version | str starts-with "*") {{value: ($version | str substring 1..), description: "current global"}} else {{value: $version, description: ""}} } |
There was a problem hiding this comment.
nitpick: The * star indicates the version is currently selected, not that it is 'current global'. I'm not familiar with nushell so I may not be reading this correctly. Maybe just say current version?
|
Thanks for the PR @OJarrisonn and sorry for the late reply. I left one comment about the description on the installed version preceded by a |
|
Thanks for the PR @OJarrisonn ! Changes merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improved completions for commands such as
asdf global <name> <version>to list the installed versionsAdded "complete asdf plugin versions installed" and "complete asdf plugin versions all" that produce completions for the installed versions and for all versions available for a given plugin
Improved
asdf installcompletion to list the installed plugins and all the available versionsFixes: no fixes
Other Information