test: unset ASDF_DATA_DIR and ASDF_CONFIG_FILE during test #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bootleq
changed the title
|
+1 I was just running unit tests... had this exact problem. Great PR |
Like ASDF_DIR, these two are also likely to be set by user's login shell, especially the shimmed `bats` (which calls `asdf_cmd()`) command will eventually set them to user's actual in-use ones, causing conflicts with the temporary test setup.
bootleq
force-pushed
the
test-unset-vars
branch
from
7592ae8 to
a08dd7c
Compare
Stratus3D
approved these changes
Dec 17, 2024
|
Sorry for the late review here. Looks great @bootleq ! I've encountered this issue myself, never had a chance to fix it. |
Stratus3D
added a commit
that referenced
this pull request
Dec 18, 2024
Co-authored-by: Trevor Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The purpose of this small change is very similar to 6d8d77f which unset
ASDF_DIR.In user's login shell with asdf,
ASDF_DATA_DIRandASDF_CONFIG_FILEwill be set / exported when calling shimmed commands, in test workflow the command isbats.For quick reproduce, login with ASDF_DIR set to
~/.asdfand having shimmedbatscommand, then run tests:bats test/uninstall_command.bats --filter 'uninstall command executes configured pre hook'bats test/list_command.bats --filter 'list_command with plugin should list installed versions'will fail due to aforementioned problem.