Remove Shaape support #320
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaape fails on all environments and is no longer maintained [1] 1. christiangoltz/shaape#20
|
I'm not inclined to remove the glue code even if we can no longer test it easily. Someone somewhere might be using this in a documentation pipeline so removing this would be a breaking change. Perhaps on a 3.x branch we could do this. |
|
@pepijnve sure, the linked issue indicated to me that it doesn't work on python 2.7 and I can't see it working on python 3 as the code hasn't been updated for over 6 years. I'll look at creating a branch for stuff like this perhaps. |
pepijnve
force-pushed
the
master
branch
2 times, most recently
from
c91ef06
to
adc02e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shaape fails on all environments and is no longer maintained [1]