feat: add encoded_len and encoded_zigzag_len
#13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rluvaton
commented
May 15, 2025
Comment on lines
+74
to
+87
| // Break the number into 7-bit parts and spread them out into a vector | ||
| let stage1: __m128i = core::mem::transmute(num.num_to_vector_stage1()); | ||
|
|
||
| // Create a mask for where there exist values | ||
| // This signed comparison works because all MSBs should be cleared at this point | ||
| // Also handle the special case when num == 0 | ||
| let minimum = _mm_set_epi8(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0xffu8 as i8); | ||
| let exists = _mm_or_si128(_mm_cmpgt_epi8(stage1, _mm_setzero_si128()), minimum); | ||
| let bits = _mm_movemask_epi8(exists); | ||
|
|
||
| // Count the number of bytes used | ||
| let bytes = 32 - bits.leading_zeros(); // lzcnt on supported CPUs | ||
|
|
||
| bytes as usize |
There was a problem hiding this comment.
Once #12 is merged I will and support here as well for non sse2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8