Correct the reusable actions version tags in the CI workflows #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfitz
requested review from
D-Dulius,
divyasharma-arup,
gac55 and
panostsolerid
mfitz
commented
Mar 31, 2025
| needs: test | ||
| if: needs.test.result == 'success' | ||
| uses: arup-group/actions-city-modelling-lab/.github/workflows/[email protected].1 | ||
| uses: arup-group/actions-city-modelling-lab/.github/workflows/[email protected].0 |
Contributor
Author
There was a problem hiding this comment.
I used the broken tag here, but the correct tag on line 17, above, so the main linting and testing bit succeeded, but the AWS upload failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, the PR I merged to fix the builds used the wrong git tag for some of the actions (
v1.1.1doesn't exist; we needv1.1.0- see here). Unfortunately, one of the places where the tag was correct was (part of) the CI commit workflow, so the build was fixed for that workflow but broken for the Daily CI, so we only discovered it was broken after merging:Checklist
Any checks which are not relevant to the PR can be pre-checked by the PR creator.
All others should be checked by the reviewer(s).
You can add extra checklist items here if required by the PR.