Potential fix for code scanning alert no. 2: Overly permissive regular expression range #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/arup-group/github-action-benchmark/security/code-scanning/2
To fix the overly permissive regular expression range, we need to ensure that the dash (
-) character in the character class is treated as a literal-rather than the beginning of or part of a range. The standard ways to do this are:\-).In this case, inside the regex
/^(?<name>Benchmark\w+[\w()$%^&*-=|,[\]{}"#]*?)(?<procs>-\d+)?\s+(?<times>\d+)\s+(?<remainder>.+)$/;, we should escape the dash:Change
[\w()$%^&*-=|,[\]{}"#]*?to[\w()$%^&*\-=|,[\]{}"#]*?.Update the regular expression on line 360 of
src/extract.tswith the escaped dash. No new imports or additional code changes are needed.Suggested fixes powered by Copilot Autofix. Review carefully before merging.