Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] - Review app infinite disco #14997

Open
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

egdbear
Copy link
Contributor

@egdbear egdbear commented Dec 16, 2024

The type of this PR is: Feat

This PR solves [PROJECT-XX]

Description

https://infinite-disco-v2.artsy.net/infinite-discovery

Screenshot 2024-11-21 at 11 32 38 AM
Screenshot 2024-11-21 at 11 32 48 AM

@egdbear egdbear requested a review from a team December 16, 2024 14:14
@egdbear egdbear self-assigned this Dec 16, 2024
@egdbear egdbear requested a review from nickskalkin December 16, 2024 14:14
@ArtsyOpenSource
Copy link

ArtsyOpenSource commented Dec 19, 2024

Warnings
⚠️

Routes added to routes.tsx should have a corresponding cypress.js smoke test. See the cypress/e2e folder for examples.

Generated by 🚫 dangerJS against c1c81b9

Copy link

relativeci bot commented Dec 19, 2024

#1549 Bundle Size — 8.99MiB (+0.27%).

c1c81b9(current) vs 13ff2dd main#1548(baseline)

Warning

Bundle contains 14 duplicate packages – View duplicate packages

Bundle metrics  Change 6 changes Regression 1 regression
                 Current
#1549
     Baseline
#1548
Regression  Initial JS 3.66MiB(+0.42%) 3.64MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 45.06% 39.37%
Change  Chunks 104(+0.97%) 103
Change  Assets 107(+0.94%) 106
Change  Modules 5838(+0.02%) 5837
No change  Duplicate Modules 523 523
Change  Duplicate Code 4%(-0.5%) 4.02%
No change  Packages 266 266
No change  Duplicate Packages 13 13
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#1549
     Baseline
#1548
Regression  JS 8.85MiB (+0.26%) 8.83MiB
Regression  Other 144.68KiB (+0.92%) 143.36KiB

Bundle analysis reportBranch review-app-infinite-disco-v2Project dashboard


Generated by RelativeCIDocumentationReport issue

@egdbear egdbear force-pushed the review-app-infinite-disco-v2 branch from 2595ad7 to 9fc2dd4 Compare December 19, 2024 09:53
@egdbear egdbear force-pushed the review-app-infinite-disco-v2 branch 2 times, most recently from 83c8827 to 51e2a20 Compare January 13, 2025 16:29
@egdbear egdbear force-pushed the review-app-infinite-disco-v2 branch from 45c3d80 to 6424c91 Compare January 16, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants