Merge pull request #15122 from artsy/DIA-1090-artist-c-vs-pages-missi…

…ng-h-1-tag fix(dia-1090): adds h1 tag to artist CV pages
artsy · Jan 28, 2025 · 35e2ef1 · 35e2ef1
2 parents 44ae801 + b4f5951
commit 35e2ef1
Show file tree

Hide file tree

Showing 27 changed files with 108 additions and 102 deletions.
diff --git a/src/Apps/Artist/Routes/CV/ArtistCVRoute.tsx b/src/Apps/Artist/Routes/CV/ArtistCVRoute.tsx
@@ -1,4 +1,4 @@
-import { Join, Spacer } from "@artsy/palette"
+import { Stack, Text } from "@artsy/palette"
 import { MetaTags } from "Components/MetaTags"
 import type { ArtistCVRoute_viewer$data } from "__generated__/ArtistCVRoute_viewer.graphql"
 import type * as React from "react"
@@ -18,9 +18,13 @@ const ArtistCVRoute: React.FC<React.PropsWithChildren<ArtistCVRouteProps>> = ({
 
   return (
     <>
-      <MetaTags title={`${viewer?.soloShows?.name} - CV | Artsy`} />
+      <MetaTags title={`${viewer?.soloShows?.name} CV | Artsy`} />
+
+      <Stack gap={4}>
+        <Text as="h1" variant="xl">
+          {viewer.soloShows?.name} CV
+        </Text>
 
-      <Join separator={<Spacer y={4} />}>
         <ArtistCVGroupRefetchContainer
           artist={viewer.soloShows}
           title="Solo shows"
@@ -35,7 +39,7 @@ const ArtistCVRoute: React.FC<React.PropsWithChildren<ArtistCVRouteProps>> = ({
           artist={viewer.fairBooths}
           title="Fair booths"
         />
-      </Join>
+      </Stack>
     </>
   )
 }

diff --git a/src/Apps/Artist/Routes/CV/Components/ArtistCVGroup.tsx b/src/Apps/Artist/Routes/CV/Components/ArtistCVGroup.tsx
@@ -44,7 +44,9 @@ const ArtistCVGroup: FC<React.PropsWithChildren<ArtistCVGroupProps>> = ({
     return (
       <GridColumns>
         <Column span={12}>
-          <Text variant="lg-display">{title}</Text>
+          <Text as="h2" variant="lg-display">
+            {title}
+          </Text>
         </Column>
 
         <Column span={8} start={4}>

diff --git a/src/__generated__/NotificationQuery.graphql.ts b/src/__generated__/NotificationQuery.graphql.ts
diff --git a/src/__generated__/NotificationViewingRoom_viewingRoom.graphql.ts b/src/__generated__/NotificationViewingRoom_viewingRoom.graphql.ts
diff --git a/src/__generated__/PartnerViewingRoomsGrid_Test_Query.graphql.ts b/src/__generated__/PartnerViewingRoomsGrid_Test_Query.graphql.ts
diff --git a/src/__generated__/PartnerViewingRoomsGrid_ViewingRoomsQuery.graphql.ts b/src/__generated__/PartnerViewingRoomsGrid_ViewingRoomsQuery.graphql.ts
diff --git a/src/__generated__/ShowApp_Test_Query.graphql.ts b/src/__generated__/ShowApp_Test_Query.graphql.ts
diff --git a/src/__generated__/ShowViewingRoom_Test_Query.graphql.ts b/src/__generated__/ShowViewingRoom_Test_Query.graphql.ts
diff --git a/src/__generated__/ShowViewingRoom_show.graphql.ts b/src/__generated__/ShowViewingRoom_show.graphql.ts
diff --git a/src/__generated__/ViewingRoomApp_ClosedTest_Query.graphql.ts b/src/__generated__/ViewingRoomApp_ClosedTest_Query.graphql.ts
diff --git a/src/__generated__/ViewingRoomApp_DraftTest_Query.graphql.ts b/src/__generated__/ViewingRoomApp_DraftTest_Query.graphql.ts
diff --git a/src/__generated__/ViewingRoomApp_LoggedOutTest_Query.graphql.ts b/src/__generated__/ViewingRoomApp_LoggedOutTest_Query.graphql.ts