-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors/http service encode params #631
Open
asheren
wants to merge
2
commits into
arsduo:master
Choose a base branch
from
asheren:refactors/http-service-encode-params
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactors/http service encode params #631
asheren
wants to merge
2
commits into
arsduo:master
from
asheren:refactors/http-service-encode-params
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to decrese the complexity of the method while maintaining functionality, The `encode_from_param` method was broken in to a separate class with smaller methods, which should also allow for easier debugging if there is ever an issue in the future.
Added nodoc to the class since it is already documented in `http_service.rb` Tested back to ruby-2.2.3
For sanity sake, here are the tests that failed on master:
and here are the ones that failed on this branch:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not meant to change any functionality, the goal was simply to refactor the
encoded_params
method. No new tests were added and no functionality was changed.Tested back to ruby-2.2.3
There appeared to be test breakage at ruby-2.3 and prior to ruby-2.2, ByeBug breaks, but those breakages seem to be unrelated to this refactor.
LIVE=true rspec
-- unrelated failures are okay).