add week and quarter for thai language in locales.py #1213
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1213 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2324 2335 +11
Branches 357 357
=========================================
+ Hits 2324 2335 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -4020,10 +4020,14 @@ class ThaiLocale(Locale): | |||
| "minutes": "{0} นาที", | |||
| "hour": "1 ชั่วโมง", | |||
| "hours": "{0} ชั่วโมง", | |||
| "week": "1 สัปดาห์", | |||
There was a problem hiding this comment.
Hi @fremzuck thanks for the contribution! Mind adding some unit tests for these new cases?
There was a problem hiding this comment.
I had a problem when using the .humanize(locale='th-th') function when the received date is more than 7 days, so I added this part. I tested it on my machine and it works fine.
What test result you want to review ?
There was a problem hiding this comment.
Just adding a couple of basic unit tests to test this locale usage like other locales in the test_locales.py test file.
|
Hi @fremzuck all the tests are failing right now. I am working on fixing Windows tests, but mac and linux should at least pass |
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
toxormake testto find out!).tox -e lintormake lintto find out!).masterbranch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes