Support different 'types' of garage door openers. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
value is spelled slightly differently for newer garage door openers with built-in Wi-Fi (Garage Door Opener WGDO).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MyQDeviceTypeName value is spelled slightly differently for newer garage door openers with
built-in Wi-Fi (Garage Door Opener WGDO).
See, for example this mention of the same issue: https://community.home-assistant.io/t/myq-componenet-issues/1860/43
I'd love to have it done in a more generic and future-proof way, maybe based upon the attributes that the device has, if there are more than a couple of these different spellings in the wild, but I think this conservative approach (just list all possible device type names) will do for now.