Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple doors #1

Merged
merged 3 commits into from
Nov 7, 2016
Merged

Support for multiple doors #1

merged 3 commits into from
Nov 7, 2016

Conversation

kylerw
Copy link
Contributor

@kylerw kylerw commented Nov 6, 2016

allows for multiple doors and uses the name defined in the Chamberlain/Liftmaster app

allows for multiple doors and uses the name defined in the Chamberlain/Liftmaster app
@rbflurry
Copy link

rbflurry commented Nov 7, 2016

To satisfy the new Async error you are seeing in the logs can you add the following.

This can go at the very bottom of the file.

    def update(self):
        self._status = self.myq.get_status(self.device_id)

Then remove line 247 "status = self.myq.get_status(self.device_id)" from the is_closed Property

and add "self._status = None" under line 232

@kylerw
Copy link
Contributor Author

kylerw commented Nov 7, 2016

@rbflurry yep, changes and pr submitted. is_closed needed one other minor update: return self._status == STATE_CLOSED - all appears to be working great. May be better to default the door to closed (right now it is open until the first update() is run). Let me know what you think or how it works for you.

@rbflurry
Copy link

rbflurry commented Nov 7, 2016

Sorry I missed the is_closed change. To make the doors load as closed change line 233 from

 self._status = None

to

 self._status = 'closed'

@arraylabs arraylabs merged commit 46c8253 into arraylabs:master Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants