Inclusive Testing #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inclusive_scan_operations.py file was not calling the correct function, had to add that in with the correct c pointer calls. Dove into the c++ files for the dim assertion error, realized that was just an issue with the c++ file, fixed that as well. The test_inclusive.py file didn't have F16 coverage, checked for that as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a suite of unit tests for accum(), scan(), scan_by_key(), and where() located within the within the vector algorithms directory. This PR also resolves issues from the inclusive_scan_operations.py file, specifically with calling particular functions, which spilled up to C++ resolution for scan_by_key.
Bug Resolution: Fixed c_type calling for the methods themselves. Scan_by_key was calling scan.name incorrectly, similar issue with the where() function. Additionally, the specific error raised by scan_by_key had to be resolved in the c++ origin file.
General Functionality: Tests confirm that the library accurately handles tests across various array shapes and dimensions, ensuring these operations perform correctly from scalars up to four-dimensional arrays. This encompasses verifying the maintenance of result dimensions in accordance with input shapes.
Data Type and Edge Case Handling: The library's robustness is tested against a comprehensive set of data types including integers, floating-points, and complex numbers (where applicable), affirming operation compatibility and precision. Additionally, scenarios involving shape mismatches, negative dimensions, and zero-sized arrays are explored (granted these cause segfaults), expecting runtime errors to prevent undefined behaviors.