Skip to content

Fix typos, duplicated params, keywords casing #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LiborKuchejda
Copy link

I was not able to run scripts right away. There were small typos and function overloads with params that were similar to other function definitions because of default values.
Fixing those, tested on azure database for postgre v10
Thanks for your effort.

@jhillacre
Copy link

Looking to bump this pull request, as this repo's code in master doesn't run without these changes from the fork.

Copy link
Contributor

@rhux rhux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the function deletion from file 8. Then I'll approve the rest of the changes.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants