-
-
Notifications
You must be signed in to change notification settings - Fork 269
SASL_SSL OAUTHBEARER support for high level consumer #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
81bcd7e
to
431d216
Compare
hey @arnaud-lb Is there any way to make the pipeline run? Is there anything else that needs to be done to move forward with this PR? No pressure, I just am trying to figure out how things work here. |
Waiting for the one to be merged soon. |
@oaattia Is there anything I can do to speed up the PR process? |
I don't know, I just need this feature :) |
cad6236
to
4e90890
Compare
Thank you @Rastusik! I fixed the pipeline and took the liberty of fixing some minor issues. The new test seems to be unstable, could you check? |
@arnaud-lb thank you for the fixes. |
I even manually reproduced the github ci tests script locally and I'm still not getting any error compared to the ones that are here. tested in ubuntu 24.04 docker image |
Thank you @Rastusik! |
Thanks a lot @arnaud-lb ! :) |
Thanks @arnaud-lb |
This PR addresses #580 .
I also extracted the main logic into a separate
oauthbearer.c
file, so it's not copy pasted into 2 places.I will be happy for any help or support or feedback, since this is the first time I'm working on a PHP extension.
EDIT: I also needed to implement the
poll()
method toKafkaConsumer
because I had problems with callinggetMetadata()
andgetCommittedOffsets()
.