Skip to content

SASL_SSL OAUTHBEARER support for high level consumer #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 26, 2025

Conversation

Rastusik
Copy link
Contributor

@Rastusik Rastusik commented Apr 15, 2025

This PR addresses #580 .

I also extracted the main logic into a separate oauthbearer.c file, so it's not copy pasted into 2 places.

I will be happy for any help or support or feedback, since this is the first time I'm working on a PHP extension.

EDIT: I also needed to implement the poll() method to KafkaConsumer because I had problems with calling getMetadata() and getCommittedOffsets().

@Rastusik
Copy link
Contributor Author

Rastusik commented Apr 16, 2025

hey @arnaud-lb Is there any way to make the pipeline run? Is there anything else that needs to be done to move forward with this PR? No pressure, I just am trying to figure out how things work here.

@oaattia
Copy link

oaattia commented Apr 19, 2025

Waiting for the one to be merged soon.

@Rastusik
Copy link
Contributor Author

Rastusik commented May 6, 2025

@oaattia Is there anything I can do to speed up the PR process?

@oaattia
Copy link

oaattia commented May 7, 2025

I don't know, I just need this feature :)
may be @arnaud-lb can help with that

@arnaud-lb
Copy link
Owner

Thank you @Rastusik!

I fixed the pipeline and took the liberty of fixing some minor issues.

The new test seems to be unstable, could you check?

@Rastusik
Copy link
Contributor Author

@arnaud-lb thank you for the fixes.
Regarding the test problems, I am not really able to reproduce them in my local setup (I tried with PHP 8.2). Do you have any hints how to reproduce the environment/problems or should I just try to use all the scripts that GH actions is using and run them in the same environment? But still I don't understand how I'm not getting any errors with php 8.2.0 and librdkafka 2.3.0-1build2

@Rastusik
Copy link
Contributor Author

I even manually reproduced the github ci tests script locally and I'm still not getting any error compared to the ones that are here. tested in ubuntu 24.04 docker image

@arnaud-lb
Copy link
Owner

arnaud-lb commented May 26, 2025

Turns out it was a timeout issue. I've increased the timeout (e8a5651 / b59da85) and tests are passing now.

@arnaud-lb arnaud-lb merged commit 285314d into arnaud-lb:6.x May 26, 2025
42 of 54 checks passed
@arnaud-lb
Copy link
Owner

Thank you @Rastusik!

@Rastusik
Copy link
Contributor Author

Thanks a lot @arnaud-lb ! :)

@oaattia
Copy link

oaattia commented May 30, 2025

Thanks @arnaud-lb
I'm eager for the next release to start using this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants