Skip to content

Fixes for null comparison #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arnabnandy7 merged 1 commit into from
Jun 8, 2026
Merged

Fixes for null comparison #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/lib/compare.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,10 @@ function getDiffType(
return undefined;
}

if (baseline.value === null || target.value === null) {
return 'CHANGED';
}

return getJsonType(baseline.value) === getJsonType(target.value)
? 'CHANGED'
: 'TYPE_CHANGE';
Expand Down
24 changes: 24 additions & 0 deletions test/lib/compare.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,30 @@ describe('compareJson', () => {
]);
});

it('reports null comparisons as value changes instead of type changes', () => {
expect(
compareJson(
{ text: null, count: 1 },
{ text: 'ready', count: null },
{ text: null, count: 2 },
),
).toEqual([
{
path: 'count',
type: 'CHANGED',
devValue: 1,
qaValue: null,
prodValue: 2,
},
{
path: 'text',
type: 'CHANGED',
devValue: null,
qaValue: 'ready',
},
]);
});

it('returns separate rows when one environment changes type and another changes value', () => {
expect(
compareJson(
Expand Down
Loading