Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from spinnaker:master #51

Merged
merged 27 commits into from
Sep 28, 2023
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Jun 13, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

spinnakerbot and others added 2 commits June 12, 2023 23:38
Co-authored-by: root <root@92f374466e67>
Co-authored-by: root <root@dd6eae37ba45>
@armory-io
Copy link

armory-io bot commented Jun 13, 2023

PR title: [pull] master from spinnaker:master does not meet Armory Engineering best practices around conventional commits.

Reason: The category was missing. EX: category: description or category(scope): description. Common Categories: build, ci, chore, docs, feat, fix, perf, refactor, revert, style, test, ops

Because we enforce conventional commits and squash merges of PRs, the PR Title becomes the commit title.

<type>[optional scope]: <description> <- The PR title becomes this part.

[optional body] <- You can add this when you merge your PR.

[optional footer] <- You can add this when you merge your PR.

For more information, see the Conventional Commits specification.

Some common examples are:

docs: correct spelling of CHANGELOG
chore!: drop Node 6 from testing matrix
chore(ops)!: drop Node 6 from testing matrix
feat(armory.io): add docs.armory.io
fix(parser): grammar and spelling
style(loadingPage): made it super pretty!
refactor(helpMessages): changed order to make more sense

@pull pull bot added the ⤵️ pull label Jun 13, 2023
j-sandy and others added 25 commits June 13, 2023 18:38
Co-authored-by: root <root@472ca8f5b9ef>
Co-authored-by: root <root@3e57035cdeb4>
Co-authored-by: root <root@4689353c0091>
Co-authored-by: root <root@117fc153e271>
…RDERING_V2) for gradle dependencies (#996)

With gradle 6.x, used [feature preview API](https://docs.gradle.org/7.6.1/userguide/feature_lifecycle.html#feature_preview) to take advantage of [improvised dependency version ordering](https://docs.gradle.org/6.5/release-notes.html#improved-dependency-version-ordering). This feature is made public for gradle 7.x. So, removing it from settings.gradle as we moved to gradle 7.6.1
Co-authored-by: root <root@d2d98ccc4dc3>
* chore(dependencies): Autobump korkVersion

* fix(manifests/tests): keep up with the removal of RetrofitException.networkError

from spinnaker/kork#1068

---------

Co-authored-by: root <root@5b63b9f2870c>
Co-authored-by: David Byron <[email protected]>
Co-authored-by: root <root@32a873e77872>
This commit adds artifact storage to rosco. When rosco sends a request
out to any service, any embedded/base64 artifacts will be automatically
stored.

Signed-off-by: benjamin-j-powell <[email protected]>
Co-authored-by: Benevolent Benjamin Powell <[email protected]>
Co-authored-by: Nicolas Favre-Felix <[email protected]>
…p in rosco (#1001)

Before refactor, total test cases executed were 275.
After refactor, total test cases executed are 275.
Co-authored-by: root <root@f8ef020c63db>
Co-authored-by: root <root@ec9c63b0f36f>
* feat(manifests/helmfile): install helmfile binary

* feat(manifests/helmfile): add code

feat(manifests/helmfile): add tests

* copyright

Signed-off-by: Salvatore Mazzarino <[email protected]>

* test changes

Signed-off-by: Salvatore Mazzarino <[email protected]>

* add javadoc

Signed-off-by: Salvatore Mazzarino <[email protected]>

* make the code dry

Signed-off-by: Salvatore Mazzarino <[email protected]>

* reduce value paths

Signed-off-by: Salvatore Mazzarino <[email protected]>

* avoid using wildcards

Signed-off-by: Salvatore Mazzarino <[email protected]>

* reduce redundant code

Signed-off-by: Salvatore Mazzarino <[email protected]>

* increase reuse

Signed-off-by: Salvatore Mazzarino <[email protected]>

* run spotless

Signed-off-by: Salvatore Mazzarino <[email protected]>

* run another round of spotless

Signed-off-by: Salvatore Mazzarino <[email protected]>

---------

Signed-off-by: Salvatore Mazzarino <[email protected]>
Co-authored-by: Salvatore Mazzarino <[email protected]>
Co-authored-by: Jason <[email protected]>
Co-authored-by: Salvatore Mazzarino <[email protected]>
Co-authored-by: root <root@fa12a2dcfdcb>
Co-authored-by: root <root@5311700f8a74>
Co-authored-by: root <root@5679483c4563>
Co-authored-by: root <root@93077bea7ae9>
Co-authored-by: root <root@6bedcb21b99e>
* chore(dependencies): Autobump korkVersion

* keep up with removal of RetrofitException in spinnaker/kork#1093

---------

Co-authored-by: root <root@16303388d012>
Co-authored-by: David Byron <[email protected]>
Co-authored-by: root <root@e80c8a2bc097>
Co-authored-by: root <root@a56c90295f1d>
Co-authored-by: root <root@bead69e1d3ab>
Co-authored-by: root <root@79235d6bc01c>
)

Before refactor, total test cases executed were 275.
After refactor, total test cases executed are 275.
@jasonmcintosh jasonmcintosh merged commit b0cc7d7 into armory-io:master Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants