Skip to content

Commit

Permalink
fix(retrofit): change retrofit and retrofit2 into api dependencies (s…
Browse files Browse the repository at this point in the history
…pinnaker#1094)

With RetrofitError (from retrofit1) and retrofit2.client.Response and retrofit2.Response
as SpinnakerHttpException constructor arguments, code that uses SpinnakerHttpException
needs these jars.

Without them,
https://github.com/spinnaker/clouddriver/actions/runs/5967605769/job/16189606342 fails
with:

./gradlew :clouddriver-aws:integrationTest

> Task :clouddriver-aws:compileTestGroovy FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':clouddriver-aws:compileTestGroovy'.
> retrofit2.Response

Co-authored-by: Jason <[email protected]>
  • Loading branch information
dbyron-sf and jasonmcintosh authored Aug 24, 2023
1 parent 26986c9 commit 5b33c24
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions kork-retrofit/kork-retrofit.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ apply from: "$rootDir/gradle/lombok.gradle"

dependencies {
api(platform(project(":spinnaker-dependencies")))
api "com.squareup.retrofit:retrofit"
api "com.squareup.retrofit2:retrofit"

implementation project(":kork-web")

implementation "com.squareup.retrofit:retrofit"
implementation "com.jakewharton.retrofit:retrofit1-okhttp3-client"
implementation "com.squareup.retrofit:converter-jackson"
implementation "io.zipkin.brave:brave-instrumentation-okhttp3"
implementation "com.squareup.retrofit2:retrofit"
implementation "com.squareup.retrofit2:converter-jackson"
implementation "com.squareup.okhttp3:logging-interceptor"
implementation "com.google.guava:guava"
Expand Down

0 comments on commit 5b33c24

Please sign in to comment.