Skip to content

chunk workflows: export the runner's oci_cache as OCI_PROXY - #83

Merged
igorpecovnik merged 1 commit into
mainfrom
oci-proxy
Oct 2, 2026
Merged

igorpecovnik merged 1 commit into
mainfrom
oci-proxy

Conversation

@igorpecovnik

@igorpecovnik igorpecovnik commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Goal: CI builds use the runner's OCI cache.

Export the runner's oci_cache as OCI_PROXY instead of GHCR_MIRROR_ADDRESS. The build ignored GHCR_MIRROR_ADDRESS without GHCR_MIRROR=dockerproxy.

Same as armbian/actions runner-clean: the build framework reads a
pull-through OCI cache from OCI_PROXY (armbian/build#10860);
GHCR_MIRROR_ADDRESS alone did nothing.

Signed-off-by: Igor Pecovnik <igor@armbian.com>
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 533fa965-6152-42f8-86e3-df56396122e1

📥 Commits

Reviewing files that changed from the base of the PR and between 59d46ed and 1d84a89.

📒 Files selected for processing (2)
  • .github/workflows/build-artifacts-chunk.yml
  • .github/workflows/build-images-chunk.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

Both chunk workflows now map the oci_cache runner-map entry to OCI_PROXY instead of GHCR_MIRROR_ADDRESS. The workflow comments now identify OCI_PROXY as the proxy variable. Other runner mappings and the artifact workflow’s proxy-variable clearing loop remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 1d84a

The workflow mapping is correctly handed to the build step; compatibility with the selected external build revision should be covered by normal integration validation.

Architecture Summary

Architecture risk: 🔵 Low · up to 1d84a

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/build-artifacts-chunk.yml: The runner map now exports oci_cache as OCI_PROXY rather than GHCR_MIRROR_ADDRESS; the comment describing the map is updated to name OCI_PROXY. The ambient proxy-variable clearing loop is unchanged.
  • observed — Modified behavior in .github/workflows/build-images-chunk.yml: The runner-map comment now identifies OCI_PROXY as the proxy variable, and the oci_cache entry is mapped to OCI_PROXY instead of GHCR_MIRROR_ADDRESS. The other mappings remain unchanged.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely states the main change: exporting the runner's oci_cache as OCI_PROXY in chunk workflows.
Description check ✅ Passed The description directly explains the CI cache change, the variable replacement, the dependency, and the affected runner configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added 11 Milestone: Fourth quarter release size/small PR with less then 50 lines labels Sep 29, 2026
@github-actions github-actions Bot added GitHub Actions GitHub Actions code Needs review Seeking for review labels Sep 29, 2026
@igorpecovnik
igorpecovnik marked this pull request as ready for review September 29, 2026 19:26
@igorpecovnik
igorpecovnik merged commit 5c5b0e6 into main Oct 2, 2026
5 checks passed
@igorpecovnik
igorpecovnik deleted the oci-proxy branch October 2, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

11 Milestone: Fourth quarter release GitHub Actions GitHub Actions code Needs review Seeking for review size/small PR with less then 50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant