Update to latest Plonky3 #1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges are needed now for test passing
nuke-web3
commented
May 8, 2025
| //Generating proofs for the program | ||
| let vmair = VMAir {}; | ||
| vmair.generate_proof(vm); | ||
| vmair.generate_proof(vm).expect("end-to-end proof generation") |
There was a problem hiding this comment.
otherwise unused Result warning
Comment on lines
+25
to
+35
| type Val = Mersenne31; | ||
| type Challenge = BinomialExtensionField<Val, 3>; | ||
| type ByteHash = Keccak256Hash; | ||
| type FieldHash = SerializingHasher<ByteHash>; | ||
| type MyCompress = CompressionFunctionFromHasher<ByteHash, 2, 32>; | ||
| type ValMmcs = MerkleTreeMmcs<Val, u8, FieldHash, MyCompress, 32>; | ||
| type ChallengeMmcs = ExtensionMmcs<Val, Challenge, ValMmcs>; | ||
| type Challenger = SerializingChallenger32<Val, HashChallenger<u8, ByteHash, 32>>; | ||
| type Pcs = CirclePcs<Val, ValMmcs, ChallengeMmcs>; | ||
| #[allow(dead_code)] | ||
| type MyConfig = StarkConfig<Pcs, Challenge, Challenger>; |
There was a problem hiding this comment.
slightly cleaner IMHO to place here, but unsure
#[allow(dead_code)] to reduce strange warning of these not being used 🤷
Comment on lines
106
to
112
| let fri_config = FriConfig { | ||
| log_blowup: 1, | ||
| num_queries: 40, | ||
| proof_of_work_bits: 8, | ||
| mmcs: challenge_mmcs, | ||
| log_final_poly_len: todo!(), | ||
| }; |
There was a problem hiding this comment.
new item in struct I am not sure how to decide on.
Comment on lines
+40
to
+41
| let local = main.row_slice(0).unwrap(); | ||
| let next = main.row_slice(1).unwrap(); |
There was a problem hiding this comment.
unsure this is correct. Perhaps leads to e2e failure?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Update to a recent Plonky3 and other deps.
Also clean up a bit &
cargo fixto reduce warningsPresent status: need to read up on API changes and get e2e test passing
@armanthepythonguy if you are interested in this getting pr to a place it can be merged, let me know 😁 . Thanks a ton for making this!