Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.5 #379

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Release 0.5 #379

wants to merge 6 commits into from

Conversation

mmagician
Copy link
Member

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@mmagician mmagician requested a review from Pratyush October 28, 2024 11:26
members = [
"relations",
"snark",
]

resolver = "2"

[workspace.package]
version = "0.5.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be "0.5.0"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had an accidental abort during the release of 0.5 for this crate, and it ended in a weird half-published state on crates.io

@Pratyush
Copy link
Member

Looks like we never had a std feature on the snark crate! Could you please add one @mmagician ?

@Pratyush
Copy link
Member

Currently this PR doesn't pass CI and can't merge; can we fix this @mmagician ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants