Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to GR1CS #154

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Migrate to GR1CS #154

wants to merge 9 commits into from

Conversation

alireza-shirzad
Copy link

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@Pratyush
Copy link
Member

Please add a bash script which automates the migration.

@Pratyush Pratyush marked this pull request as ready for review March 3, 2025 19:29
@Pratyush Pratyush requested a review from a team as a code owner March 3, 2025 19:29
@Pratyush Pratyush requested review from z-tech, mmagician and weikengchen and removed request for a team March 3, 2025 19:29
z-tech
z-tech reviewed Mar 4, 2025
View reviewed changes
scripts/migrate.sh
fi

echo "###############################################"
echo "# ⚠️ Cautious: RUN THIS SCRIPT ONLY ONCE! DO NOT RUN IT TWICE! #"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if you run this twice?

@z-tech
Copy link

z-tech commented Mar 4, 2025

Could we fill in the description?

Is this purely a name change? And do we need or want this to be a breaking change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z-tech z-tech z-tech left review comments

@Pratyush Pratyush Pratyush approved these changes

@mmagician mmagician Awaiting requested review from mmagician mmagician is a code owner automatically assigned from arkworks-rs/maintainers

@weikengchen weikengchen Awaiting requested review from weikengchen weikengchen is a code owner automatically assigned from arkworks-rs/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alireza-shirzad @Pratyush @z-tech