-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix. Changed += to = in FieldVar double_in_place #142
base: master
Are you sure you want to change the base?
Bug fix. Changed += to = in FieldVar double_in_place #142
Conversation
Wasn't there a unit test for this before? Could you add one for future proofing? |
I don't see any tests for |
@mmagician What do you think, can we merge it? |
It's currently failing due to recently introduced breaking changes in |
@mmagician, @Pratyush removed unused imports, should pass now. |
🤔 Something changed in algebra with |
Can we rerun failing |
Description
Fixed bug in Field_var::double_in_place
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the Github PR explorer