Fix visibility of get_limbs_representations
#139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Also additional tiny style fix.)
skaunov
requested review from
z-tech,
mmagician and
weikengchen
and removed request for
a team
Pratyush
reviewed
Feb 8, 2024
| /// functions | ||
| pub fn get_limbs_representations( | ||
| /// functions. | ||
| pub(super) fn get_limbs_representations( |
There was a problem hiding this comment.
I think it's fine to leave this public, as possibly downstream code might need to use it. Maybe we can mark it as #[doc(hidden)] instead?
There was a problem hiding this comment.
I have code that uses it, don't see why it has to be hidden even.
|
My move was just aligning docs and code. X)
So, if it's a first-class citizen of the API, let's rewrite its doc! Ok?
…On Thu, Feb 8 2024 at 02:30:46 AM -0800, Kristian Sosnin ***@***.***> wrote:
***@***.**** commented on this pull request.
In src/fields/emulated_fp/allocated_field_var.rs
<#139 (comment)>:
> /// This is an internal function that would be reused by a
number of other
- /// functions
- pub fn get_limbs_representations(
+ /// functions.
+ pub(super) fn get_limbs_representations(
I have code that uses it, don't see why it has to be hidden even.
—
Reply to this email directly, view it on GitHub
<#139 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APXLOTYUYB2A2BJG4Q6JVZLYSSSNNAVCNFSM6AAAAABC622JV6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNRZG44DCNBWGA>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Sure, let's keep it |
|
Will update the PR! Give me some time to collect tiny things like
`Self` in this one for inclusion all at once.
…On Fri, Feb 9 2024 at 06:12:40 AM -0800, Pratyush Mishra ***@***.***> wrote:
Sure, let's keep it pub and change the doc. @skaunov
<https://github.com/skaunov> if you want to update the PR to do that,
that would be great
—
Reply to this email directly, view it on GitHub
<#139 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APXLOTYWTXOEL5JJC4X6MLDYSYVFRAVCNFSM6AAAAABC622JV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZWGAYDEOBYHE>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Pratyush
approved these changes
Mar 19, 2024
Pratyush
reviewed
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Also additional tiny style fix.)