Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup docs #153

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Cleanup docs #153

merged 2 commits into from
Oct 21, 2024

Conversation

rubdos
Copy link
Contributor

@rubdos rubdos commented Oct 20, 2024 •
edited
Loading

Description

Cleans a bunch of warnings emitted during cargo doc, and resolves some unresolved links.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@rubdos rubdos requested a review from a team as a code owner October 20, 2024 08:42
@rubdos rubdos requested review from z-tech, mmagician and tyshko-rostyslav and removed request for a team October 20, 2024 08:42
Pratyush
Pratyush approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@Pratyush Pratyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@Pratyush Pratyush enabled auto-merge October 21, 2024 15:39
@Pratyush Pratyush added this pull request to the merge queue Oct 21, 2024
Merged via the queue into arkworks-rs:main with commit 26a1514 Oct 21, 2024
5 checks passed
@rubdos rubdos deleted the clean-docs branch October 21, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pratyush Pratyush Pratyush approved these changes

@z-tech z-tech Awaiting requested review from z-tech z-tech is a code owner automatically assigned from arkworks-rs/maintainers

@mmagician mmagician Awaiting requested review from mmagician mmagician is a code owner automatically assigned from arkworks-rs/maintainers

@tyshko-rostyslav tyshko-rostyslav Awaiting requested review from tyshko-rostyslav tyshko-rostyslav is a code owner automatically assigned from arkworks-rs/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubdos @Pratyush