Added size check to Bowe-Hopwood gadget evaluate
method
#120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the Bowe-Hopwood CRH gadget would silently fail to hash inputs whose bitlength exceeded
NUM_WINDOWS * WINDOW_SIZE * 3
. This makes it easy to miss simple things in development, but it's probably not a security issue, since any gadget eval is almost certainly accompanied by a native eval, which does have the size check. Instead, it should say that the input is too large, as the Pedersen CRH gadget does.This PR adds the check, and also a regression test.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the Github PR explorer