Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment that does not match the code #116

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

Insun35
Copy link
Contributor

@Insun35 Insun35 commented Sep 11, 2023

Description

Fix the comment that does not match the code in src/sponge/absorb.rs line 68:
"Append the list to dest." -> "Return the list as Vec."

As the function batch_to_sponge_field_elements_as_vec returns Vec,
the changed comment is more appropriate.

  • Targeted PR against correct branch (main)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests (comment line doesn't need a unit test)
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md (It doesn't need a change log, because it is not a significant change)
  • Re-reviewed Files changed in the Github PR explorer

@Pratyush Pratyush merged commit 1e4f16c into arkworks-rs:main Sep 11, 2023
4 checks passed
@Insun35 Insun35 deleted the fix-comment branch September 23, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants