Remove unneeded permute from Poseidon hashing (#152)

* removed unneeded permutes * tests are consistent * Apply suggestions from code review * formatting --------- Co-authored-by: Eli Margolin <[email protected]> Co-authored-by: Pratyush Mishra <[email protected]> Co-authored-by: Eli Margolin <[email protected]> Co-authored-by: Pratyush Mishra <[email protected]> Co-authored-by: Eli Margolin <[email protected]>
arkworks-rs · Oct 16, 2024 · e51fc42 · e51fc42
1 parent 8fbf5ef
commit e51fc42
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 5 deletions.
diff --git a/crypto-primitives/src/sponge/poseidon/constraints.rs b/crypto-primitives/src/sponge/poseidon/constraints.rs
@@ -224,7 +224,6 @@ impl<F: PrimeField> CryptographicSpongeVar<F, PoseidonSponge<F>> for PoseidonSpo
             DuplexSpongeMode::Squeezing {
                 next_squeeze_index: _,
             } => {
-                self.permute()?;
                 self.absorb_internal(0, input.as_slice())?;
             }
         };

diff --git a/crypto-primitives/src/sponge/poseidon/mod.rs b/crypto-primitives/src/sponge/poseidon/mod.rs
@@ -251,7 +251,6 @@ impl<F: PrimeField> CryptographicSponge for PoseidonSponge<F> {
             DuplexSpongeMode::Squeezing {
                 next_squeeze_index: _,
             } => {
-                self.permute();
                 self.absorb_internal(0, elems.as_slice());
             }
         };

diff --git a/crypto-primitives/src/sponge/poseidon/tests.rs b/crypto-primitives/src/sponge/poseidon/tests.rs
@@ -111,9 +111,6 @@ fn run_cross_test<F: PrimeField + Absorb>(cfg: &PoseidonConfig<F>) {
                 match self.mode() {
                     SpongeMode::Absorbing => self.absorbing.extend_from_slice(input),
                     SpongeMode::Squeezing => {
-                        // Wash the state as mode changes
-                        // This is not appied in SAFE sponge
-                        permute(&self.cfg, &mut self.state);
                         // Append inputs to the absorbing line
                         self.absorbing.extend_from_slice(input);
                         // Change mode to absorbing