ec: implement double-odd curves #986
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubdos
requested review from
Pratyush,
mmagician and
weikengchen
and removed request for
a team
|
As a side note: I recall a discussion on Discord where there was a parameter dump for a DO curve that embeds Curve25519, but I don't have the link at hand. Here are the SW parameters: |
Pratyush
requested changes
May 21, 2025
| ); | ||
|
|
||
| fn double_in_place(&mut self) -> &mut Self { | ||
| self.z = -P::get_c().double() * self.t.square(); // Self.z == -2cT^2 |
There was a problem hiding this comment.
Can you add a link/reference to the algorithm being implemented here?
There was a problem hiding this comment.
Does this link suffice?
|
Pushed a few fixups, will discuss the rest with @Tarinn when we both have time at the office! Thanks for the review so far. |
rubdos
force-pushed
the
double-odd-public
branch
4 times, most recently
from
19b1822 to
e084df6
Compare
Implements Thomas Pornin's “A Prime-Order Group with Complete Formulas from Even-Order Elliptic Curves” [1], often referred to as "double odd" curves. Includes the double-odd curve “JQ255s” as presented in the paper. [1] T. Pornin, “A Prime-Order Group with Complete Formulas from Even-Order Elliptic Curves,” IACR CiC, vol. 1, no. 1, p. 33, Apr. 2024, doi: 10.62056/akmp-4c2h.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Thomas Pornin's “A Prime-Order Group with Complete Formulas from Even-Order Elliptic Curves” [1], often referred to as "double odd" curves.
Includes the double-odd curve “JQ255s” as presented in the paper.
[1] T. Pornin, “A Prime-Order Group with Complete Formulas from Even-Order Elliptic Curves,” IACR CiC, vol. 1, no. 1, p. 33, Apr. 2024, doi: 10.62056/akmp-4c2h.
This is work by @Tarinn
Description
closes: #490
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer