Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #950

Closed
wants to merge 1 commit into from
Closed

Conversation

owenzimmew06
Copy link

I suggest two corrections in this document:

First; "equal 2 or 3" sgould be "equals 2 or 3"

In "directly (i.e. m equal 2 or 3)," "equal" should be "equals" for proper grammar,

Second; "holding two base field elements" → "which holds two base field elements"

In "Struct representing a quadratic extension field, in this case holding two base field elements," restructuring improves clarity.

Thanks.

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

I suggest two corrections in this document:

First; "equal 2 or 3" sgould be "equals 2 or 3"

In "directly (i.e. m equal 2 or 3)," "equal" should be "equals" for proper grammar,

Second; "holding two base field elements" → "which holds two base field elements"

In "Struct representing a quadratic extension field, in this case holding two base field elements," restructuring improves clarity.

Thanks.
@owenzimmew06 owenzimmew06 requested review from a team as code owners March 5, 2025 14:28
@owenzimmew06 owenzimmew06 requested review from z-tech, Pratyush and weikengchen and removed request for a team March 5, 2025 14:28
@z-tech
Copy link
Contributor

z-tech commented Mar 5, 2025

Thanks for your contribution. Unfortunately, we are closing this PR. Please refer to our contribution guidelines for more details. We look forward to your next contribution!

@z-tech z-tech closed this Mar 5, 2025
@arkworks-rs arkworks-rs locked and limited conversation to collaborators Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants