Skip to content

Conversation

@Bashmunta
Copy link

Removed an unreachable spill buffer path in generate_impl and deletes the corresponding add_buffer helper that injected a Rust variable declaration into the asm instruction stream. The path was dead because only num_limbs <= 6 are supported while MAX_REGS is 6; if ever activated, it would produce invalid inline assembly by embedding non-asm Rust code and by referencing a variable outside Rust scope via an asm operand, and moreover the buf operand was never used in the assembly template. Eliminating this code prevents a latent compile-time error, has no effect on current supported configurations, and clarifies that support for larger limb counts needs a proper prologue-based buffer setup and explicit usage in asm if added in the future.

@Bashmunta Bashmunta requested review from a team as code owners November 27, 2025 08:59
@Bashmunta Bashmunta requested review from Pratyush, weikengchen and z-tech and removed request for a team November 27, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant