-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bluealsa-aplay: option to select volume mode #664
Conversation
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard for me to judge the user experience with such --volume=
option (volume control is not my every day use case here), but from the code point of view it looks great!
To be honest, nor is it mine. I do not use The motivation for this PR comes from PR #662, and is three-fold:
I've pushed a new commit to address the review comments so far, and am happy to make further changes is requested. |
Yes, I think that this feature provides very generic solution without much complexity. I'll play with it a bit and I think it's ready to go to master. Many thanks for that! |
cc8c0ca
to
842c7eb
Compare
842c7eb
to
3a820d8
Compare
A proposal to improve
bluealsa-aplay
volume control. Inspired by the discussion in PR #662, this proposal gives thebluealsa-aplay
utility the ability to select soft volume or pass-through volume control independently of thebluealsa
service defaults.Default behavior remains unchanged, so backwards compatibility for existing installations is maintained.
See the changes to
doc/bluealsa-aplay.1.rst
for details of the new command-line option and the various new behaviors made available.