Refactor _EntityPool to use generations and free slots

[ameligrana]

No description provided.

[github-actions]

boxed = false

🚀 14 benchmark improvements detected!

⚠️ 7 benchmark regressions detected!

Click to expand benchmark results

Time is per entity/N, allocations are totals. Allocations are only shown for current.

N	Time main	Time curr	Factor	Allocs	Bytes
query_create
1000	5.92ns	5.91ns	1.00	0	0
query_create_filter
1000	5.97ns	5.96ns	1.00	0	0
query_posvel_1k_arch
100	5.96ns	6.12ns	1.03	0	0
1000	8.69ns	8.86ns	1.02	0	0
10000	2.60ns	2.55ns	0.98	0	0
100000	1.05ns	1.07ns	1.02	0	0
1000000	0.83ns	0.81ns	0.97	0	0
query_posvel_1k_arch_cached
100	7.10ns	7.22ns	1.02	0	0
1000	9.93ns	10.03ns	1.01	0	0
10000	2.72ns	2.72ns	1.00	0	0
100000	1.00ns	1.09ns	1.09	0	0
1000000	0.80ns	0.81ns	1.01	0	0
query_posvel_32_arch
100	2.13ns	2.12ns	0.99	0	0
1000	0.72ns	0.70ns	0.98	0	0
10000	0.45ns	0.46ns	1.01	0	0
100000	0.65ns	0.63ns	0.97	0	0
1000000	0.65ns	0.68ns	1.05	0	0
query_posvel_cold
100	0.90ns	0.90ns	1.00	0	0
1000	0.39ns	0.39ns	1.00	0	0
10000	0.37ns	0.39ns	1.05	0	0
100000	0.66ns	0.65ns	0.98	0	0
1000000	0.80ns	0.89ns	⚠️ 1.11	0	0
query_posvel_fields
100	0.43ns	0.43ns	1.00	0	0
1000	0.24ns	0.24ns	1.00	0	0
10000	0.32ns	0.32ns	1.00	0	0
100000	0.47ns	0.41ns	🚀 0.88	0	0
1000000	0.55ns	0.59ns	1.07	0	0
query_posvel_fields_broadcast
100	0.91ns	0.92ns	1.00	0	0
1000	0.73ns	0.73ns	1.00	0	0
10000	0.78ns	0.78ns	0.99	0	0
100000	0.95ns	0.82ns	🚀 0.88	0	0
1000000	1.37ns	1.43ns	1.05	0	0
query_posvel_hot
100	0.55ns	0.53ns	0.96	0	0
1000	0.25ns	0.25ns	0.99	0	0
10000	0.33ns	0.33ns	1.00	0	0
100000	0.47ns	0.40ns	🚀 0.87	0	0
1000000	0.57ns	0.58ns	1.02	0	0
query_posvel_mean
100	1.07ns	1.07ns	1.00	0	0
100000	0.95ns	0.95ns	1.00	0	0
query_posvel_mean_readonly
100	1.07ns	1.07ns	1.00	0	0
100000	0.95ns	0.95ns	1.00	0	0
query_posvel_soa
100	1.44ns	1.44ns	1.00	0	0
1000	1.31ns	1.32ns	1.00	0	0
10000	1.36ns	1.36ns	1.00	0	0
100000	1.37ns	1.37ns	1.00	0	0
1000000	1.39ns	1.40ns	1.01	0	0
query_posvel_soa_unpack
100	0.47ns	0.49ns	1.03	0	0
1000	0.25ns	0.25ns	1.00	0	0
10000	0.32ns	0.32ns	1.00	0	0
100000	0.47ns	0.40ns	🚀 0.87	0	0
1000000	0.55ns	0.60ns	1.10	0	0
world_add_remove_1
100	32.61ns	32.75ns	1.00	0	0
10000	32.88ns	33.42ns	1.02	0	0
world_add_remove_1_batch
100	4.08ns	4.13ns	1.01	0	0
10000	2.89ns	2.88ns	1.00	0	0
world_add_remove_1_buffer
100	36.64ns	36.72ns	1.00	0	0
10000	37.01ns	36.88ns	1.00	0	0
world_add_remove_1_buffer_single
100	39.28ns	38.92ns	0.99	0	0
10000	38.21ns	38.32ns	1.00	0	0
world_add_remove_1_large
100	46.04ns	55.35ns	⚠️ 1.20	0	0
10000	46.94ns	56.34ns	⚠️ 1.20	0	0
world_add_remove_1_soa
100	38.01ns	38.00ns	1.00	0	0
10000	38.66ns	38.19ns	0.99	0	0
world_add_remove_8
100	56.03ns	55.62ns	0.99	0	0
10000	56.99ns	56.93ns	1.00	0	0
world_add_remove_8_large
100	75.99ns	76.40ns	1.01	0	0
10000	77.15ns	77.73ns	1.01	0	0
world_add_remove_8_soa
100	77.09ns	77.34ns	1.00	0	0
10000	78.89ns	79.26ns	1.00	0	0
world_copy_entity_5
100	25.85ns	26.30ns	1.02	0	0
10000	25.70ns	26.01ns	1.01	0	0
world_get_1
100	1.06ns	1.14ns	1.07	0	0
10000	0.96ns	1.04ns	1.09	0	0
world_get_1_soa
100	1.76ns	1.81ns	1.03	0	0
10000	1.67ns	1.73ns	1.04	0	0
world_get_5
100	3.02ns	2.94ns	0.97	0	0
10000	2.93ns	2.85ns	0.97	0	0
world_get_5_unchecked
100	1.85ns	1.82ns	0.99	0	0
10000	1.83ns	1.79ns	0.98	0	0
world_get_rel
100	1.04ns	1.07ns	1.03	0	0
10000	0.94ns	0.95ns	1.01	0	0
world_has_1
100	0.95ns	1.08ns	⚠️ 1.14	0	0
10000	0.85ns	0.98ns	⚠️ 1.16	0	0
world_has_5
100	1.04ns	1.16ns	⚠️ 1.12	0	0
10000	0.95ns	1.07ns	⚠️ 1.12	0	0
world_new_entities_1
100	3.10ns	1.86ns	🚀 0.60	0	0
10000	2.29ns	1.08ns	🚀 0.47	0	0
world_new_entities_1_def
100	3.00ns	1.90ns	🚀 0.63	0	0
10000	2.41ns	1.21ns	🚀 0.50	0	0
world_new_entities_5
100	5.11ns	4.11ns	🚀 0.80	0	0
10000	3.94ns	2.73ns	🚀 0.69	0	0
world_new_entities_5_def
100	4.91ns	3.81ns	🚀 0.78	0	0
10000	3.93ns	2.69ns	🚀 0.68	0	0
world_new_entity_1
100	12.43ns	12.53ns	1.01	0	0
10000	12.43ns	12.35ns	0.99	0	0
world_new_entity_1_rel
100	40.58ns	42.72ns	1.05	0	0
10000	40.60ns	42.38ns	1.04	0	0
world_new_entity_1_soa
100	13.98ns	13.83ns	0.99	0	0
10000	13.81ns	13.56ns	0.98	0	0
world_new_entity_5
100	21.64ns	21.49ns	0.99	0	0
10000	21.86ns	21.72ns	0.99	0	0
world_new_entity_5_rel
100	54.11ns	55.55ns	1.03	0	0
10000	55.18ns	57.14ns	1.04	0	0
world_new_entity_5_soa
100	31.01ns	30.76ns	0.99	0	0
10000	31.60ns	31.38ns	0.99	0	0
world_partition
100	17.79ns	17.63ns	0.99	0	0
10000	28.84ns	27.77ns	0.96	0	0
world_posvel
100	3.37ns	3.28ns	0.97	0	0
10000	3.43ns	3.33ns	0.97	0	0
world_remove_entities_5
100	2.25ns	1.70ns	🚀 0.75	0	0
10000	0.97ns	0.69ns	🚀 0.71	0	0
world_remove_entity_5
100	18.84ns	20.09ns	1.07	0	0
10000	18.60ns	19.66ns	1.06	0	0
world_resource
1	8.11ns	8.10ns	1.00	0	0
world_set_1
100	3.29ns	2.99ns	0.91	0	0
10000	3.42ns	3.10ns	0.91	0	0
world_set_1_soa
100	2.78ns	2.74ns	0.99	0	0
10000	2.90ns	2.87ns	0.99	0	0
world_set_5
100	15.32ns	15.32ns	1.00	0	0
10000	16.86ns	16.05ns	0.95	0	0
world_set_rel
100	44.13ns	44.28ns	1.00	0	0
10000	43.93ns	44.12ns	1.00	0	0
world_set_rel_batch
100	2.41ns	2.46ns	1.02	0	0
10000	0.76ns	0.76ns	1.00	0	0
world_shuffle
100	65.92ns	64.47ns	0.98	0	0
10000	85.14ns	82.12ns	0.96	0	0
world_sort
100	64.62ns	64.37ns	1.00	0	0
10000	219.35ns	220.11ns	1.00	0	0
world_update_1
100	3.86ns	3.98ns	1.03	0	0
10000	4.02ns	4.15ns	1.03	0	0
world_update_5
100	8.63ns	8.28ns	0.96	0	0
10000	9.23ns	8.89ns	0.96	0	0

boxed = true

🚀 9 benchmark improvements detected!

⚠️ 9 benchmark regressions detected!

Click to expand benchmark results

Time is per entity/N, allocations are totals. Allocations are only shown for current.

N	Time main	Time curr	Factor	Allocs	Bytes
query_create
1000	14.34ns	14.65ns	1.01	0	0
query_create_filter
1000	14.33ns	14.70ns	1.02	0	0
query_posvel_1k_arch
100	5.42ns	5.56ns	1.03	0	0
1000	6.07ns	5.93ns	0.97	0	0
10000	1.60ns	1.61ns	1.00	0	0
100000	1.20ns	1.18ns	0.99	0	0
1000000	1.17ns	1.12ns	0.96	0	0
query_posvel_1k_arch_cached
100	5.78ns	5.84ns	1.01	0	0
1000	6.40ns	6.46ns	1.01	0	0
10000	1.63ns	1.68ns	1.03	0	0
100000	1.20ns	1.21ns	1.00	0	0
1000000	1.08ns	1.10ns	1.02	0	0
query_posvel_32_arch
100	2.04ns	2.05ns	1.01	0	0
1000	0.64ns	0.64ns	1.01	0	0
10000	0.40ns	0.41ns	1.00	0	0
100000	0.77ns	0.76ns	1.00	0	0
1000000	0.86ns	0.87ns	1.01	0	0
query_posvel_cold
100	0.96ns	0.93ns	0.96	0	0
1000	0.40ns	0.39ns	0.97	0	0
10000	0.38ns	0.38ns	1.00	0	0
100000	0.79ns	0.80ns	1.02	0	0
1000000	1.20ns	1.28ns	1.09	0	0
query_posvel_fields
100	0.41ns	0.41ns	1.00	0	0
1000	0.21ns	0.22ns	1.08	0	0
10000	0.35ns	0.36ns	1.05	0	0
100000	0.71ns	0.77ns	⚠️ 1.10	0	0
1000000	0.82ns	0.87ns	1.06	0	0
query_posvel_fields_broadcast
100	1.27ns	1.34ns	1.05	0	0
1000	1.09ns	1.15ns	1.05	0	0
10000	1.02ns	1.10ns	1.06	0	0
100000	1.49ns	1.57ns	1.04	0	0
1000000	1.77ns	1.88ns	1.07	0	0
query_posvel_hot
100	0.55ns	0.60ns	1.07	0	0
1000	0.23ns	0.23ns	1.01	0	0
10000	0.35ns	0.36ns	1.05	0	0
100000	0.71ns	0.70ns	1.00	0	0
1000000	0.86ns	0.85ns	0.98	0	0
query_posvel_mean
100	0.87ns	0.89ns	1.03	0	0
100000	1.00ns	1.04ns	1.05	0	0
query_posvel_mean_readonly
100	0.88ns	0.89ns	1.01	0	0
100000	1.00ns	1.02ns	1.02	0	0
query_posvel_soa
100	1.38ns	1.37ns	0.99	0	0
1000	1.22ns	1.22ns	1.00	0	0
10000	1.20ns	1.24ns	1.04	0	0
100000	1.25ns	1.28ns	1.02	0	0
1000000	1.28ns	1.28ns	1.00	0	0
query_posvel_soa_unpack
100	0.48ns	0.48ns	1.00	0	0
1000	0.24ns	0.25ns	1.04	0	0
10000	0.36ns	0.36ns	1.00	0	0
100000	0.75ns	0.77ns	1.01	0	0
1000000	0.83ns	0.84ns	1.01	0	0
world_add_remove_1
100	58.16ns	58.75ns	1.01	0	0
10000	58.43ns	59.98ns	1.03	0	0
world_add_remove_1_batch
100	4.81ns	4.72ns	0.97	0	0
10000	2.75ns	2.79ns	1.02	0	0
world_add_remove_1_buffer
100	65.98ns	65.71ns	0.99	0	0
10000	65.73ns	67.01ns	1.01	0	0
world_add_remove_1_buffer_single
100	63.88ns	63.11ns	0.99	0	0
10000	64.16ns	63.51ns	0.99	0	0
world_add_remove_1_large
100	58.11ns	58.15ns	1.00	0	0
10000	57.79ns	58.63ns	1.01	0	0
world_add_remove_1_soa
100	63.77ns	66.03ns	1.03	0	0
10000	64.41ns	66.39ns	1.02	0	0
world_add_remove_8
100	90.66ns	87.89ns	0.97	0	0
10000	90.28ns	89.27ns	0.99	0	0
world_add_remove_8_large
100	91.61ns	88.57ns	0.96	0	0
10000	91.46ns	89.52ns	0.98	0	0
world_add_remove_8_soa
100	112.54ns	110.19ns	0.98	0	0
10000	113.60ns	113.27ns	1.00	0	0
world_copy_entity_5
100	78.47ns	76.73ns	0.98	0	0
10000	78.88ns	75.50ns	0.96	0	0
world_get_1
100	1.04ns	1.06ns	1.01	0	0
10000	1.01ns	1.02ns	1.01	0	0
world_get_1_soa
100	1.67ns	1.66ns	0.99	0	0
10000	1.63ns	1.63ns	0.99	0	0
world_get_5
100	4.84ns	4.69ns	0.96	0	0
10000	4.75ns	4.77ns	1.00	0	0
world_get_5_unchecked
100	3.19ns	3.07ns	0.96	0	0
10000	3.12ns	3.07ns	0.99	0	0
world_get_rel
100	0.96ns	0.97ns	1.01	0	0
10000	0.94ns	0.94ns	1.01	0	0
world_has_1
100	0.83ns	1.05ns	⚠️ 1.29	0	0
10000	0.83ns	1.00ns	⚠️ 1.21	0	0
world_has_5
100	0.97ns	1.09ns	⚠️ 1.11	0	0
10000	0.94ns	1.06ns	⚠️ 1.13	0	0
world_new_entities_1
100	3.43ns	2.05ns	🚀 0.60	0	0
10000	2.44ns	1.19ns	🚀 0.48	0	0
world_new_entities_1_def
100	3.29ns	1.97ns	🚀 0.60	0	0
10000	2.52ns	1.30ns	🚀 0.51	0	0
world_new_entities_5
100	6.13ns	4.83ns	🚀 0.79	0	0
10000	4.39ns	3.32ns	🚀 0.75	0	0
world_new_entities_5_def
100	5.90ns	4.37ns	🚀 0.74	0	0
10000	3.86ns	2.73ns	🚀 0.71	0	0
world_new_entity_1
100	12.53ns	12.43ns	0.99	0	0
10000	12.18ns	12.27ns	1.01	0	0
world_new_entity_1_rel
100	33.53ns	32.74ns	0.97	0	0
10000	32.63ns	32.58ns	1.00	0	0
world_new_entity_1_soa
100	14.09ns	13.89ns	0.99	0	0
10000	13.92ns	13.68ns	0.98	0	0
world_new_entity_5
100	22.62ns	27.33ns	⚠️ 1.18	0	0
10000	22.13ns	27.26ns	⚠️ 1.20	0	0
world_new_entity_5_rel
100	46.31ns	45.59ns	0.99	0	0
10000	46.07ns	45.23ns	0.98	0	0
world_new_entity_5_soa
100	31.50ns	30.02ns	0.95	0	0
10000	31.54ns	30.17ns	0.95	0	0
world_partition
100	33.56ns	33.43ns	0.99	0	0
10000	45.45ns	43.88ns	0.96	0	0
world_posvel
100	3.42ns	3.50ns	1.03	0	0
10000	3.61ns	3.62ns	1.01	0	0
world_remove_entities_5
100	2.75ns	2.50ns	0.91	0	0
10000	1.03ns	0.80ns	🚀 0.79	0	0
world_remove_entity_5
100	73.44ns	75.68ns	1.04	0	0
10000	75.87ns	75.25ns	0.99	0	0
world_resource
1	7.60ns	7.65ns	1.00	0	0
world_set_1
100	2.03ns	2.03ns	1.01	0	0
10000	2.36ns	2.16ns	0.90	0	0
world_set_1_soa
100	3.17ns	2.98ns	0.93	0	0
10000	3.23ns	3.13ns	0.96	0	0
world_set_5
100	7.21ns	7.41ns	1.02	0	0
10000	8.47ns	8.38ns	0.98	0	0
world_set_rel
100	48.72ns	55.36ns	⚠️ 1.12	0	0
10000	46.86ns	52.52ns	⚠️ 1.10	0	0
world_set_rel_batch
100	2.95ns	2.99ns	1.01	0	0
10000	0.94ns	0.92ns	0.98	0	0
world_shuffle
100	124.55ns	119.05ns	0.94	0	0
10000	139.86ns	135.19ns	0.95	0	0
world_sort
100	70.71ns	66.34ns	0.93	0	0
10000	243.32ns	231.67ns	0.95	0	0
world_update_1
100	2.77ns	2.60ns	0.93	0	0
10000	2.94ns	2.94ns	0.98	0	0
world_update_5
100	11.98ns	12.18ns	1.01	0	0
10000	13.15ns	13.01ns	0.98	0	0

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!