Skip to content

Comments

[claude] Starting commit message generation#76

Merged
arittr merged 4 commits into8a076f-task-1-logger-foundationfrom
8a076f-task-2-generator-agent-integration
Nov 3, 2025
Merged

[claude] Starting commit message generation#76
arittr merged 4 commits into8a076f-task-1-logger-foundationfrom
8a076f-task-2-generator-agent-integration

Conversation

@arittr
Copy link
Owner

@arittr arittr commented Nov 3, 2025

[claude] Checking CLI availability
[claude] CLI is available
[claude] Executing command
[claude] Command executed, output length: 599
[claude] Cleaning response
[claude] Response cleaned, length: 547
[claude] Validating response format
[claude] Response validated successfully
feat: integrate logger interface into agent system

  • Add logger injection to BaseAgent constructor for debugging support
  • Update agent factory to accept and propagate logger to agent instances
  • Add debug logging at key lifecycle points in BaseAgent.generate()
  • Update all BaseAgent subclasses in tests to pass logger via constructor
  • Modify Generator to use logger interface instead of inline warn function
  • Update CLI to instantiate ConsoleLogger for generator configuration
  • Add optional logger property to Agent interface type definition

🤖 Generated with Claude via commitment

[claude] Checking CLI availability
[claude] CLI is available
[claude] Executing command
[claude] Command executed, output length: 599
[claude] Cleaning response
[claude] Response cleaned, length: 547
[claude] Validating response format
[claude] Response validated successfully
feat: integrate logger interface into agent system

- Add logger injection to BaseAgent constructor for debugging support
- Update agent factory to accept and propagate logger to agent instances
- Add debug logging at key lifecycle points in BaseAgent.generate()
- Update all BaseAgent subclasses in tests to pass logger via constructor
- Modify Generator to use logger interface instead of inline warn function
- Update CLI to instantiate ConsoleLogger for generator configuration
- Add optional logger property to Agent interface type definition

🤖 Generated with Claude via commitment
refactor: integrate logger interface throughout CLI layer

- Replace direct console.log/error calls with logger interface in CLI entry point
- Pass logger instances to helper functions (displayStagedChanges, displayGenerationStatus, displayCommitMessage, executeCommit)
- Create logger in main command based on --quiet flag (ConsoleLogger vs SilentLogger)
- Update init command to always use ConsoleLogger (never quiet)
- Simplify helper unit tests to use SilentLogger instead of mocking console
- Update checkGitStatusOrExit to use logger.warn/info instead of console

🤖 Generated with Claude via commitment
- Add logger parameter to ChatGPTAgent, MetaEvaluator, and SingleAttemptEvaluator constructors
- Pass logger through EvalRunner and AttemptRunner to dependent components
- Update all test files to inject SilentLogger into evaluator and runner instances
- Update run-eval.ts to instantiate EvalRunner with ConsoleLogger
- Remove direct console.log calls in favor of logger interface pattern

🤖 Generated with Claude via commitment
Implements:
- Updated prepare-commit-msg hook to check {2} parameter
- Hook only runs commitment when {2} is empty (regular commits)
- Preserves messages for git commit -m and merge commits
- Updated hook to use commands instead of jobs for consistency
- Added explanatory comments matching example hooks

Acceptance criteria met:
✅ lefthook.yml checks {2} parameter before running commitment
✅ git commit generates message (hook runs)
✅ git commit -m "test" preserves message (hook skips)
✅ Merge commits preserve messages (hook skips)
✅ commitment dogfooding still works
✅ Examples already correct (no changes needed)
@arittr arittr merged commit 2b33bdc into 8a076f-task-1-logger-foundation Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant