Skip to content

refactor: establish SUPPORTED_AGENTS as single source of truth#62

Merged
arittr merged 4 commits intofeat-add-gemini-agent-support-tofrom
refactor-establish-supported
Oct 26, 2025
Merged

refactor: establish SUPPORTED_AGENTS as single source of truth#62
arittr merged 4 commits intofeat-add-gemini-agent-support-tofrom
refactor-establish-supported

Conversation

@arittr
Copy link
Owner

@arittr arittr commented Oct 26, 2025

  • Export SUPPORTED_AGENTS from agents/types.ts as canonical agent list
  • Update agentNameSchema to derive from SUPPORTED_AGENTS (removes hardcoded duplication)
  • Add comprehensive tests verifying schema-constant synchronization
  • Remove AgentName type export from types/schemas.ts to prevent confusion
  • Format code with updated linter rules

🤖 Generated with Claude via commitment

- Export SUPPORTED_AGENTS from agents/types.ts as canonical agent list
- Update agentNameSchema to derive from SUPPORTED_AGENTS (removes hardcoded duplication)
- Add comprehensive tests verifying schema-constant synchronization
- Remove AgentName type export from types/schemas.ts to prevent confusion
- Format code with updated linter rules

🤖 Generated with Claude via commitment
- Add Gemini to list of supported AI agents in README
- Update architecture.md with simple factory pattern using ts-pattern
- Document factory criteria: single responsibility, pure function, exhaustiveness checking
- Replace "if/else for agent selection" with "simple factory with ts-pattern"
- Update v3 evolution notes to clarify allowed vs banned factory patterns
- Add factory.ts to agent sub-components list
- Update meta.md version history with v3 factory simplification

🤖 Generated with Claude via commitment
- Add `--agent` flag to `commitment init` for setting default agent
- Implement manual argv parsing to handle Commander.js subcommand option conflict
- Display configured agent in init success message
- Update README with agent configuration examples for hook setup

🤖 Generated with Claude via commitment
- Store list of staged files before running linting
- Re-stage files modified by linting tools
- Prevent unstaged changes from being excluded from commit

🤖 Generated with Claude via commitment
@arittr arittr merged commit be37631 into feat-add-gemini-agent-support-to Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant