fix: publish artifacts bundling the runtime - #160
Merged
Conversation
…untime contamination Agent-Logs-Url: https://github.com/arition/SubRenamer/sessions/bbfbc8a7-d5a8-4bd8-ad2c-d69a9b9f21e4 Co-authored-by: arition <3581094+arition@users.noreply.github.com>
Agent-Logs-Url: https://github.com/arition/SubRenamer/sessions/495cd5cb-2818-4dfa-beae-dea4bc618102 Co-authored-by: arition <3581094+arition@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
arition
May 8, 2026 23:24
View session
arition
changed the title
Closed
arition
marked this pull request as ready for review
May 8, 2026 23:25
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions publish workflow so the “no runtime” Windows release artifacts are truly framework-dependent, while keeping the “with-runtime” artifacts self-contained, aligning the artifact outputs with their intended packaging.
Changes:
- Switch framework-dependent publishes from
--self-contained falseto--no-self-contained. - Keep runtime-bundled publishes self-contained (
--self-contained).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Framework-dependent release artifacts were still being produced with the .NET runtime bundled, making them effectively identical to the
with-runtimeartifacts.--self-contained falsewith the explicit framework-dependent flag:--no-self-contained--self-containedSubRenamer-win-*artifacts are framework-dependentSubRenamer-with-runtime-win-*artifacts remain self-contained