-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Move ansible-only tests to their own molecule scenario #5100
Merged
gmuloc
merged 17 commits into
aristanetworks:devel
from
gmuloc:test-move-inline-jinja-to-its-own-role
Mar 3, 2025
Merged
Test: Move ansible-only tests to their own molecule scenario #5100
gmuloc
merged 17 commits into
aristanetworks:devel
from
gmuloc:test-move-inline-jinja-to-its-own-role
Mar 3, 2025
+2,144
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5100
# Activate the virtual environment
source test-avd-pr-5100/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@test-move-inline-jinja-to-its-own-role#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,test-move-inline-jinja-to-its-own-role --force
# Optional: Install AVD examples
cd test-avd-pr-5100
ansible-playbook arista.avd.install_examples |
for more information, see https://pre-commit.ci
ansible_collections/arista/avd/molecule/ansible_only/custom_modules/__init__.py
Outdated
Show resolved
Hide resolved
...sta/avd/molecule/eos_designs_unit_tests/inventory/host_vars/RD-RT-ADMIN-SUBFIELD-L3LEAF6.yml
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_designs_unit_tests/inventory/hosts.yml
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_designs_unit_tests/custom_modules/__init__.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/ansible_only/inventory/group_vars/DC1_SERVERS.yml
Outdated
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
Feb 27, 2025
|
carlbuchmann
reviewed
Mar 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, reviewed refactored inline j2 test output and ensure we ported all tests overs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Test
state: CI Updated
CI scenario have been updated in the PR
type: code quality
CI and development toolset
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Currently we are excluding from pytest some hosts from eos_designs_unit_tests because they have inline Jinja. This PR separates in a new molecule scenario
ansible_only
the ansible collection only features so we can also run the rest in pytest and ⬆️ coverageComponent(s) name
ci
Proposed changes
cf summary + new molecule scenario added to CI
How to test
green molecules
Checklist
Repository Checklist