Refactor(eos_designs): Refactor structured_config code for dhcp_servers.py #5084
+77
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5084
# Activate the virtual environment
source test-avd-pr-5084/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@refactor/underlay/dhcp-servers#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,refactor/underlay/dhcp-servers --force
# Optional: Install AVD examples
cd test-avd-pr-5084
ansible-playbook arista.avd.install_examples |
laxmikantchintakindi
force-pushed
the
refactor/underlay/dhcp-servers
branch
2 times, most recently
from
d30c553 to
48635d6
Compare
Vibhu-gslab
force-pushed
the
refactor/underlay/dhcp-servers
branch
from
48635d6 to
b116eda
Compare
Vibhu-gslab
reviewed
Feb 25, 2025
python-avd/pyavd/_eos_designs/structured_config/underlay/dhcp_servers.py
Outdated
Show resolved
Hide resolved
laxmikantchintakindi
force-pushed
the
refactor/underlay/dhcp-servers
branch
from
2981872 to
0a5a215
Compare
Vibhu-gslab
reviewed
Feb 28, 2025
python-avd/pyavd/_eos_designs/structured_config/underlay/dhcp_servers.py
Outdated
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
…servers.py Co-authored-by: Vibhu-gslab <[email protected]>
Vibhu-gslab
force-pushed
the
refactor/underlay/dhcp-servers
branch
from
497e922 to
97b5a20
Compare
Vibhu-gslab
approved these changes
Feb 28, 2025
gmuloc
requested changes
Mar 3, 2025
| @cached_property | ||
| def _ipv4_ztp_boot_file(self: AvdStructuredConfigUnderlayProtocol) -> str | None: | ||
| """Returns the file name to allow for ZTP to CV. TODO: Add inband_ztp_bootstrap_file to schema.""" | ||
| dhcp_server.vrf = "default" |
There was a problem hiding this comment.
I would probably keep this in the main function rather than hiding it in the middle of the servers. Move it after the check for if len(dhcp_server.subnets) == 0:
| dhcp_server.subnets.append(subnet_item) | ||
|
|
||
| def _set_ipv4_ztp_boot_file(self: AvdStructuredConfigUnderlayProtocol, dhcp_server: EosCliConfigGen.DhcpServersItem) -> None: | ||
| """Set the file name to allow for ZTP to CV. TODO: Add inband_ztp_bootstrap_file to schema.""" |
There was a problem hiding this comment.
@laxmikantchintakindi can you please add the inband_ztp_bootstrap_file to the schema? shoud be a string
| if ntp_servers := self._ntp_servers: | ||
| dhcp_server["ipv4_vendor_options"] = [ntp_servers] | ||
| dhcp_servers.append(dhcp_server) | ||
| return |
There was a problem hiding this comment.
don't think you need this return, instead do a:
if not ntp_servers:
raise
Do the subotoptions stuff
github-actions
bot
added
state: Documentation role Updated
role: eos_designs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Refactor structured_config code for dhcp_servers.py
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_designsProposed changes
Refactor structured_config code for dhcp_servers.py
How to test
Checklist
User Checklist
Repository Checklist